fix(aria/tree): adds rtl keyboard functionality for tree #32305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essjay05
requested review from
crisbeto and
ok7sai
and removed request for
a team
essjay05
added
dev-app preview
|
Deployed dev-app for 359dfe8 to: https://ng-dev-previews-comp--pr-angular-components-32305-dev-cnx82r4a.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
wagnermaciel
approved these changes
Nov 11, 2025
src/aria/private/tree/tree.ts
Outdated
Comment on lines
171
to
173
|
|
||
| /** The text direction of the tree. */ | ||
| textDirection: SignalLike<'ltr' | 'rtl'>; |
Contributor
There was a problem hiding this comment.
We don't need to define this here because it is already an input of TreeInputs
essjay05
force-pushed
the
rtl-tree-keyboard-functionality-aria
branch
from
b081f3c to
7604b9d
Compare
ok7sai
approved these changes
Nov 11, 2025
wagnermaciel
added
action: merge
wagnermaciel
changed the title
Updates aria tree keyboard functionality to have RightArrow collapse and LeftArrow expand for rtl.
Updates previous code to remove unnecessary input.
wagnermaciel
force-pushed
the
rtl-tree-keyboard-functionality-aria
branch
from
7604b9d to
359dfe8
Compare
Contributor
wagnermaciel
pushed a commit
that referenced
this pull request
Nov 12, 2025
* feat(aria/tree): adds rtl keyboard functionality for tree Updates aria tree keyboard functionality to have RightArrow collapse and LeftArrow expand for rtl. * refactor(aria/tree): remove unnecessary input Updates previous code to remove unnecessary input. (cherry picked from commit 56304a3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates aria tree keyboard functionality to have RightArrow collapse and LeftArrow expand for rtl.