refactor(multiple): move expanded state to each expansion item #32314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok7sai
force-pushed
the
ng-aria-expansion
branch
3 times, most recently
from
1f63c5c to
706d912
Compare
ok7sai
force-pushed
the
ng-aria-expansion
branch
2 times, most recently
from
50b1eef to
a8951f5
Compare
ok7sai
added
the
dev-app preview
|
Deployed dev-app for b0d751a to: https://ng-dev-previews-comp--pr-angular-components-32314-dev-n3u39pya.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
Comment on lines
+196
to
+231
|
|
||
| afterRenderEffect(() => { | ||
| const tab = this._pattern.selectedTab(); | ||
| if (tab) { | ||
| this.selectedTab.set(tab.value()); | ||
| } | ||
| }); | ||
|
|
||
| afterRenderEffect(() => { | ||
| const value = this.selectedTab(); | ||
| if (value) { | ||
| this._pattern.open(value); | ||
| } | ||
| }); |
Contributor
There was a problem hiding this comment.
Make the individual tabs the source of truth for this. We can still expose a readonly selectedTab at the top level
wagnermaciel
approved these changes
Nov 12, 2025
Contributor
wagnermaciel
left a comment
wagnermaciel
left a comment
There was a problem hiding this comment.
LGTM with one comment
ok7sai
force-pushed
the
ng-aria-expansion
branch
from
7afdf62 to
1851f17
Compare
ok7sai
added
action: merge
ok7sai
force-pushed
the
ng-aria-expansion
branch
from
637a902 to
b0d751a
Compare
Member
Author
ok7sai
added a commit
that referenced
this pull request
Nov 12, 2025
* refactor(multiple): move expanded state to each expansion item * refactor: remove tree declaration merging * refactor: fix tests (cherry picked from commit 3b39d89)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selectedTabinput to change expanded tab/tab panel since it's always single expanded.[(expandedPanels)]) to each Accordion Trigger ([(expanded)]).