Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 42 additions & 1 deletion src/aria/toolbar/toolbar.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {Component, DebugElement, signal} from '@angular/core';
import {Component, DebugElement, Directive, inject, signal} from '@angular/core';
import {ComponentFixture, TestBed} from '@angular/core/testing';
import {By} from '@angular/platform-browser';
import {Toolbar, ToolbarWidget, ToolbarWidgetGroup} from './toolbar';
Expand Down Expand Up @@ -533,6 +533,23 @@ describe('Toolbar', () => {
expect(document.activeElement).toBe(initialActiveElement);
});
});

describe('with wrapped toolbar widgets', () => {
beforeEach(() => {
TestBed.configureTestingModule({imports: [WrappedToolbarExample]});
fixture = TestBed.createComponent(WrappedToolbarExample) as any;
fixture.detectChanges();
});

it('should navigate on click', () => {
const widgets = fixture.debugElement
.queryAll(By.css('[toolbar-button]'))
.map((debugEl: DebugElement) => debugEl.nativeElement as HTMLElement);
console.log('clicking:', widgets[0]);
click(widgets[0]);
expect(document.activeElement).toBe(widgets[0]);
});
});
});

describe('Selection', () => {
Expand Down Expand Up @@ -638,3 +655,27 @@ class ToolbarExample {

groups = [{disabled: signal(false)}];
}

@Directive({
selector: 'button[toolbar-button]',
hostDirectives: [{directive: ToolbarWidget, inputs: ['value', 'disabled']}],
host: {
type: 'button',
class: 'example-button material-symbols-outlined',
'[aria-label]': 'widget.value()',
},
})
export class SimpleToolbarButton {
widget = inject(ToolbarWidget);
}

@Component({
template: `
<div ngToolbar>
<button toolbar-button value="undo">undo</button>
<button toolbar-button value="redo">redo</button>
</div>
`,
imports: [Toolbar, SimpleToolbarButton],
})
class WrappedToolbarExample {}
3 changes: 1 addition & 2 deletions src/aria/toolbar/toolbar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,7 @@ export class Toolbar<V> {

/** Finds the toolbar item associated with a given element. */
private _getItem(element: Element) {
const widgetTarget = element.closest('[ngToolbarWidget]');
return this._itemPatterns().find(widget => widget.element() === widgetTarget);
return this._itemPatterns().find(item => item.element()?.contains(element));
}
}

Expand Down
Loading