refactor(cdk/overlay): revert internal workaround #32374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts a workaround now that it isn't necessary anymore.
crisbeto
requested review from
adolgachev and
mmalerba
and removed request for
a team
crisbeto
commented
Nov 18, 2025
|
|
||
| /** Checks if a value is an element. */ | ||
| export function isElement(value: any): value is Element { | ||
| return value && (value as Element).nodeType === 1; |
Member
Author
There was a problem hiding this comment.
We can't use instanceof Element, because it can break during SSR.
wagnermaciel
approved these changes
Nov 18, 2025
mmalerba
added
target: patch
Contributor
|
switching it to patch since we're in commit freeze |
Member
Author
crisbeto
added a commit
that referenced
this pull request
Nov 20, 2025
Reverts a workaround now that it isn't necessary anymore. (cherry picked from commit c63d735)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts a workaround now that it isn't necessary anymore.