Skip to content

refactor(cdk/overlay): re-add internal workaround #32395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2025
Merged

refactor(cdk/overlay): re-add internal workaround #32395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/cdk/overlay/overlay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,15 @@ export function createOverlayRef(injector: Injector, config?: OverlayConfig): Ov
? overlayConfig.positionStrategy?.getPopoverInsertionPoint?.()
: null;

// Note: this is redundant since the host will be moved into its final location immediately
// after. We're keeping it as a temporary workaround, because an internal team depends on
// this behavior. We can roll this back after January 5th 2026.
overlayContainer.getContainerElement().appendChild(host);

if (isElement(customInsertionPoint)) {
customInsertionPoint.after(host);
} else if (customInsertionPoint?.type === 'parent') {
customInsertionPoint.element.appendChild(host);
} else {
// Note: leave the container for last so that we fall
// back to it for unsupported/newly-added values.
overlayContainer.getContainerElement().appendChild(host);
}

return new OverlayRef(
Expand Down
Loading