fix(cdk/testing): errors in harnesses when using Vitest #32399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
mmalerba and
ok7sai
and removed request for
a team
alan-agius4
reviewed
Nov 24, 2025
Fixes that we were hitting an error due to the DOM implementation that Vitest is using when constructing events.
crisbeto
force-pushed
the
32389/vitest-events
branch
from
ff5b46a to
0d6642c
Compare
alan-agius4
reviewed
Nov 25, 2025
| // Passing `window` as the `view` on for events when the environment is using jsdom | ||
| // ends up throwing `member view is not of type Window` (see #32389). Leave it as | ||
| // `undefined` for such cases. | ||
| return typeof window !== 'undefined' && window && !(window as Window & {jsdom?: unknown}).jsdom |
Contributor
There was a problem hiding this comment.
NIT, redundant check
Suggested change
| return typeof window !== 'undefined' && window && !(window as Window & {jsdom?: unknown}).jsdom | |
| return typeof window !== 'undefined' && !(window as Window & {jsdom?: unknown}).jsdom |
Member
Author
There was a problem hiding this comment.
The check is there because technically window can be null which is typeof === 'object'.
Member
Author
crisbeto
added a commit
that referenced
this pull request
Nov 25, 2025
Fixes that we were hitting an error due to the DOM implementation that Vitest is using when constructing events. (cherry picked from commit d41d397)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that we were hitting an error due to the DOM implementation that Vitest is using when constructing events.
Fixes #32389.