fix(autocomplete): reposition panel on scroll #3745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
Member
Author
|
Probably not, but I think I have an idea on how to fix it. I'll take a better look tomorrow. |
crisbeto
force-pushed
the
autocomplete-reposition
branch
from
d07f9c2 to
3fd470e
Compare
googlebot
added
cla: no
crisbeto
force-pushed
the
autocomplete-reposition
branch
from
3fd470e to
9091959
Compare
googlebot
added
cla: yes
kara
approved these changes
Apr 20, 2017
Contributor
kara
left a comment
kara
left a comment
There was a problem hiding this comment.
LGTM, one nit. Apply merge label when rebased and ready.
| private _panelPositionSubscription: Subscription; | ||
|
|
||
| /** Subscription to global scroll events. */ | ||
| private _scrolledSubscription: Subscription; |
Repositions the autocomplete panel if the users scrolls while it is open.
crisbeto
force-pushed
the
autocomplete-reposition
branch
from
9091959 to
67104a7
Compare
crisbeto
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repositions the autocomplete panel if the users scrolls while it is open.