feat(card): added card component #44
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
src/components/card/card.scss
Outdated
There was a problem hiding this comment.
+1 space between property and value.
src/components/card/card.scss
Outdated
There was a problem hiding this comment.
The second param for md-color doesn't actually need quotes, I believe.
kara
force-pushed
the
card
branch
2 times, most recently
from
9594f47 to
9466869
Compare
src/components/card/card.ts
Outdated
There was a problem hiding this comment.
Can we put the templates in separate files?
kara
force-pushed
the
card
branch
2 times, most recently
from
0849035 to
41e7cc2
Compare
src/components/card/card.scss
Outdated
src/components/card/card.ts
Outdated
There was a problem hiding this comment.
Add
TODO(kara): update link to demo site when it exists
7429d00 to
6612669
Compare
|
LGTM |
andrewseguin
pushed a commit
to andrewseguin/components
that referenced
this pull request
Oct 15, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jelbourn @hansl @robertmesserle
Design: