-
Notifications
You must be signed in to change notification settings - Fork 59
feat(ng-dev): create tool for automatically discovering and updating generated files #2359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /** | ||
| * @license | ||
| * Copyright Google LLC | ||
| * | ||
| * Use of this source code is governed by an MIT-style license that can be | ||
| * found in the LICENSE file at https://angular.io/license | ||
| */ | ||
|
|
||
| import {Argv, CommandModule} from 'yargs'; | ||
| import {updateGeneratedFileTargets} from './update-generated-files.js'; | ||
|
|
||
| async function builder(argv: Argv) { | ||
| return argv; | ||
| } | ||
| async function handler() { | ||
| await updateGeneratedFileTargets(); | ||
| } | ||
|
|
||
| /** CLI command module. */ | ||
| export const GeneratedFilesModule: CommandModule = { | ||
| builder, | ||
| handler, | ||
| command: 'update-generated-files', | ||
| describe: 'Automatically discover all bazel generated file targets and update them.', | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /** | ||
| * @license | ||
| * Copyright Google LLC | ||
| * | ||
| * Use of this source code is governed by an MIT-style license that can be | ||
| * found in the LICENSE file at https://angular.io/license | ||
| */ | ||
|
|
||
| import {ChildProcess} from '../../utils/child-process.js'; | ||
| import {Spinner} from '../../utils/spinner.js'; | ||
| import {getBazelBin} from '../../utils/bazel-bin.js'; | ||
| import {green, Log} from '../../utils/logging.js'; | ||
|
|
||
| export async function updateGeneratedFileTargets(): Promise<void> { | ||
| const spinner = new Spinner('Querying for all generated file targets'); | ||
|
|
||
| // Query for all of the generated file targets | ||
| const result = await ChildProcess.spawn( | ||
| getBazelBin(), | ||
| ['query', `"kind(nodejs_binary, //...) intersect attr(name, '.update$', //...)"`], | ||
| {mode: 'silent'}, | ||
| ); | ||
|
|
||
| if (result.status !== 0) { | ||
| spinner.complete(); | ||
| throw Error(`Unexpected error: ${result.stderr}`); | ||
| } | ||
|
|
||
| const targets = result.stdout.trim().split(/\r?\n/); | ||
| spinner.update(`Found ${targets.length} generated file targets to update`); | ||
|
|
||
| // Build all of the generated file targets in parallel. | ||
| await ChildProcess.spawn(getBazelBin(), ['build', targets.join(' ')], {mode: 'silent'}); | ||
|
|
||
| // Individually run the generated file update targets. | ||
| for (let idx = 0; idx < targets.length; idx++) { | ||
| const target = targets[idx]; | ||
| spinner.update(`${idx + 1} of ${targets.length} updates completed`); | ||
| const updateResult = await ChildProcess.spawn(getBazelBin(), ['run', target], {mode: 'silent'}); | ||
| if (updateResult.status !== 0) { | ||
| spinner.complete(); | ||
| throw Error(`Unexpected error while updating: ${target}.`); | ||
| } | ||
| } | ||
|
|
||
| spinner.complete(); | ||
| Log.info(` ${green('✔')} Updated all generated files (${targets.length} targets)`); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| /** | ||
| * @license | ||
| * Copyright Google LLC | ||
| * | ||
| * Use of this source code is governed by an MIT-style license that can be | ||
| * found in the LICENSE file at https://angular.io/license | ||
| */ | ||
|
|
||
| import {join} from 'path'; | ||
| import {determineRepoBaseDirFromCwd} from './repo-directory.js'; | ||
|
|
||
| let BAZEL_BIN: undefined | string = undefined; | ||
|
|
||
| export function getBazelBin() { | ||
| if (BAZEL_BIN === undefined) { | ||
| BAZEL_BIN = process.env.BAZEL || join(determineRepoBaseDirFromCwd(), 'node_modules/.bin/bazel'); | ||
| } | ||
|
|
||
| return BAZEL_BIN; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.