Skip to content

fix(ng-dev): improve logging output for updating aspect files #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(ng-dev): improve logging output for updating aspect files #2536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions ng-dev/release/publish/external-commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,15 +263,19 @@ export abstract class ExternalCommands {
* to refresh Aspect lock files.
*/
static async invokeBazelUpdateAspectLockFiles(projectDir: string): Promise<void> {
const spinner = new Spinner('Updating Aspect lock files');

try {
// Note: No progress indicator needed as that is the responsibility of the command.
// TODO: Consider using an Ora spinner instead to ensure minimal console output.
await ChildProcess.spawn(getBazelBin(), ['run', '@npm2//:sync'], {cwd: projectDir});
await ChildProcess.spawn(getBazelBin(), ['run', '@npm2//:sync'], {
cwd: projectDir,
mode: 'silent',
});
} catch (e) {
// Note: Gracefully handling these errors because `sync` command
// alway exits with a non-zero exit code.
Log.debug(e);
}

Log.info(green(' ✓ Updated Aspect `rules_js` lock files.'));
spinner.success(green(' Updated Aspect `rules_js` lock files.'));
}
}
Loading