feat(ng-dev/release): support pnpm as primary package manager #2637
Conversation
devversion
force-pushed
the
pnpm-release-toolk
branch
from
b55d658 to
6156119
Compare
This commit adds support for working with `pnpm` as primary package manager. The Angular CLI repository will soon drop Yarn and this will be necessary then. There is no need for testing of anything as we don't generally test any external commands, but in the future, when we drop Yarn completely here, we can update some other assertions to "recognize pnpm".
devversion
force-pushed
the
pnpm-release-toolk
branch
from
6156119 to
d43b94e
Compare
josephperrott
left a comment
josephperrott
left a comment
There was a problem hiding this comment.
LGTM overall, just the lint errors need to be corrected.
| return existsSync(join(repoPath, 'pnpm-lock.yaml')) && !existsSync(join(repoPath, 'yarn.lock')); | ||
| } | ||
|
|
||
| async getPackageSpec(repoPath: string) { |
There was a problem hiding this comment.
getPackageSpec as a name was not obviously to me what was being returned. Primarily because I asssociated spec with testing.
I don't know if there is a better naming option, but it was a bit confusing to me on first read.
There was a problem hiding this comment.
Thanks for doing this!
|
This PR was merged into the repository by commit 17e5969. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
2 participants
This commit adds support for working with
pnpmas primary package manager. The Angular CLI repository will soon drop Yarn and this will be necessary then.There is no need for testing of anything as we don't generally test any external commands, but in the future, when we drop Yarn completely here, we can update some other assertions to "recognize pnpm".