Skip to content

fix(bazel): properly handle highlighter.js in strict deps tests #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(bazel): properly handle highlighter.js in strict deps tests #2999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions bazel/ts_project/strict_deps/index.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,16 +52,18 @@ function checkPathsForMatch(moduleSpecifier: string, paths?: ts.MapLike<string[]
return false;
}

/** The list of known package names that end with extensions and need to be special cased. */
const knownModuleSpecifiersWithExtensions = new Set(['highlight.js', 'zone.js']);

for (const fileExecPath of manifest.testFiles) {
const content = await fs.readFile(fileExecPath, 'utf8');
const sf = ts.createSourceFile(fileExecPath, content, ts.ScriptTarget.ESNext, true);
const imports = getImportsInSourceFile(sf);

for (const i of imports) {
const moduleSpecifier =
i.moduleSpecifier === 'zone.js'
? 'zone.js'
: i.moduleSpecifier.replace(extensionRemoveRegex, '');
const moduleSpecifier = knownModuleSpecifiersWithExtensions.has(i.moduleSpecifier)
? i.moduleSpecifier
: i.moduleSpecifier.replace(extensionRemoveRegex, '');
// When the module specified is the file itself this is always a valid dep.
if (i.moduleSpecifier === '') {
continue;
Expand Down