Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Most all of the new position modes are missing from the documentation. There are many typos. The explanations are not clear.

Issue Number:
Fixes #5150.

What is the new behavior?

add docs for all of the position modes
fix typos
clarify text descriptions
provide more examples
explain default positioning
fix old URL

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

N/A

fix typos
clarify text descriptions
provide more examples
explain default positioning
fix old URL

Fixes #5150.
@Splaktar Splaktar added this to the 1.1.9 milestone Mar 27, 2018
@Splaktar Splaktar requested a review from crisbeto March 27, 2018 08:10
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Mar 27, 2018
@Splaktar Splaktar added type: docs P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review labels Mar 27, 2018
@josephperrott josephperrott merged commit ecca532 into master Mar 29, 2018
@Splaktar Splaktar deleted the updateMenuDocs branch March 30, 2018 01:45
chmelevskij pushed a commit to chmelevskij/material that referenced this pull request Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review type: docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(menu): missing new position modes

3 participants