This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(datepicker): don't use the locale in the default formatting function #8162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
needs: review
crisbeto
force-pushed
the
fix/datepicker-keyb
branch
from
daaf47e to
32ef0c6
Compare
crisbeto
added
needs: review
crisbeto
force-pushed
the
fix/datepicker-keyb
branch
from
32ef0c6 to
bddb688
Compare
crisbeto
force-pushed
the
fix/datepicker-keyb
branch
from
bddb688 to
dac2b88
Compare
crisbeto
force-pushed
the
fix/datepicker-keyb
branch
from
dac2b88 to
49510cb
Compare
By default the datepicker would insert the date into the view after passing it through toLocaleDateString. This means that if the user's locale date string couldn't be parsed by `new Date` (e.g. their locale is European which formats the dates as DD/MM/YYYY), the datepicker would have inserted an invalid date. This change switches to using the US date format by default, because it is parse-able by the Date constructor. This shouldn't be unexpected, because the documentation states that users should override the date functions if they're dealing with different kinds of date formats. Fixes angular#7456. Fixes angular#7404. Fixes angular#8275.
crisbeto
force-pushed
the
fix/datepicker-keyb
branch
from
49510cb to
5ecbfd5
Compare
|
When can I get this Fix in an release version? |
|
Why the PR is closed, and how can we help to get it merged? |
|
@ferchoman09 @volodymyrlut This fix is already in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the datepicker would insert the date into the view after passing it through toLocaleDateString.
This means that if the user's locale date string couldn't be parsed by
new Date(e.g. their locale is European which formats the dates as DD/MM/YYYY), the datepicker would have inserted an invalid date.This change switches to using the US date format by default, because it is parse-able by the Date constructor. This shouldn't be unexpected, because the documentation states that users should override the date functions if they're dealing with different kinds of date formats.
Fixes #7456.
Fixes #7404.
Fixes #8275.