Skip to content
This repository was archived by the owner on Oct 12, 2021. It is now read-only.

Conversation

@mgechev
Copy link
Member

@mgechev mgechev commented Apr 21, 2016

  1. Update to TypeScript (1.9 has fix for TS4020).
  2. Update ts-node and typings.
  3. Add ambient type definitions for CacheStorage, CacheOptions, Cache.
  4. Add ambient type definitions for jshashes.
  5. Remove useless require from gulpfile.ts.
  6. Add merge-stream in order to merge both js and dts streams of
    gulp-typescript.
  7. Publish typings field in package.json.
  8. Remove inline Promise interface definition and take the one from
    es6-shim typings.

Note that the Cache interfaces does not completely align to the standard.

@jeffbcross
Copy link
Contributor

Awesome, are you planning to update the build process to emit dist/worker.d.ts as part of this PR?

@mgechev
Copy link
Member Author

mgechev commented Apr 21, 2016

Yes, sure. What do you think about the standard compatibility? Should we keep the definitions as they are, or to make align to the API in the link?

@jeffbcross
Copy link
Contributor

Personally, I see the typings as a stop gap until Cache typings are included in TypeScript. I don't think they need to be complete.

@mgechev
Copy link
Member Author

mgechev commented Apr 24, 2016

@jeffbcross everything from #15 should be here.

All merge conflicts are resolved and the PR is squashed.

@mgechev
Copy link
Member Author

mgechev commented May 8, 2016

Need to rebase. I'll do that when I land.

@mgechev
Copy link
Member Author

mgechev commented May 27, 2016

@jeffbcross, we have green build. I incorporated #27 here and added a few more enhancements on top.

I edited the commit message above with all the changes. The big diff comes from the removed node_modules directory.

Let me know if you prefer the two commits squashed into a single one.

1. Update to TypeScript (1.9 has fix for TS4020).
2. Update ts-node and typings.
3. Add ambient type definitions for CacheStorage, CacheOptions, Cache.
4. Add ambient type definitions for jshashes.
5. Remove useless require from `gulpfile.ts`.
6. Add `merge-stream` in order to merge both js and dts streams of
`gulp-typescript`.
7. Publish `typings` field in `package.json`.
8. Remove inline Promise interface definition and take the one from
`es6-shim` typings.
@jeffbcross jeffbcross merged commit 3af26c7 into angular:master May 27, 2016
@mgechev mgechev mentioned this pull request May 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants