feat(parser): perform case sensitive parsing #68
Conversation
mgechev
force-pushed
the
app-shell-case-sensitivity
branch
6 times, most recently
from
d68d613 to
17e204e
Compare
| <html> | ||
| <body> | ||
| <Div> | ||
| <Section Title="Bar"></Section> |
There was a problem hiding this comment.
Can you add more variety of mixed casing to the template?
|
A couple of comments added! By design, Angular doesn't preserve the |
mgechev
force-pushed
the
app-shell-case-sensitivity
branch
from
17e204e to
53709b4
Compare
|
@jeffbcross I addressed the comments you had. As we discussed, I'll update the Let me know if you have any other comments before being ready to merge. |
| "e2e": "protractor", | ||
| "build_publish": "rm -rf dist && tsc -p src/tsconfig.publish.es5.json && tsc -p src/tsconfig.publish.es6.json && cp src/package.json dist/package.json" | ||
| "clean": "rm -rf dist", | ||
| "build": "ng build && tsc -p src/tsconfig.publish.es5.json && tsc -p src/tsconfig.publish.es6.json && cp src/package.json dist/app/package.json && browserify dist/app/shell-parser/index.js -s shellParserFactory > dist/app/shell-parser.js && rm -rf dist/app/shell-parser && rm -rf dist/app/vendor", |
There was a problem hiding this comment.
Needs browserify dependency installed. I can take care of this.
|
LGTM. Once comments are addressed, plz merge. |
mgechev
force-pushed
the
app-shell-case-sensitivity
branch
from
53709b4 to
56e4ba0
Compare
2 participants
Monkey patches the parse5 tokenizer in order to allow case sensitive parsing. This way we can use case sensitive selector in order to strip content that should not belong to the App Shell.