Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

fix(common): remove internal monicker for FileLoader#1009

Merged
CaerusKaru merged 1 commit intomasterfrom
adam/file-loader
Jun 9, 2018
Merged

fix(common): remove internal monicker for FileLoader#1009
CaerusKaru merged 1 commit intomasterfrom
adam/file-loader

Conversation

@CaerusKaru
Copy link
Copy Markdown
Member

  • this causes issues with bundling, and is not needed since the export is already "private"

* this causes issues with bundling, and is not needed since the export is already "private"
@CaerusKaru CaerusKaru added action: review target: minor target: minor This PR is targeted for the next minor release area: common labels Jun 9, 2018
Copy link
Copy Markdown

@Toxicable Toxicable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaerusKaru CaerusKaru merged commit 23f0d0f into master Jun 9, 2018
@CaerusKaru CaerusKaru deleted the adam/file-loader branch June 9, 2018 04:02
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review area: common target: minor target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants