This repository was archived by the owner on Nov 22, 2024. It is now read-only.
feat(express-engine): add option to skip Universal schematic#1059
Merged
CaerusKaru merged 2 commits intomasterfrom Aug 26, 2018
Merged
feat(express-engine): add option to skip Universal schematic#1059CaerusKaru merged 2 commits intomasterfrom
CaerusKaru merged 2 commits intomasterfrom
Conversation
CaerusKaru
added
action: review
area: express-engine
target: minor
vikerman
approved these changes
Aug 25, 2018
| } | ||
| }; | ||
|
|
||
| if (!clientProject.architect.server) { |
Contributor
There was a problem hiding this comment.
I don't understand what this is for - Can you add a comment?
Member
Author
There was a problem hiding this comment.
Sure, it's there because if the Universal schematic wasn't run, there isn't necessarily a server entry in the project config
Contributor
There was a problem hiding this comment.
ok - Please add a comment in the code. Thanks
CaerusKaru
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.