This repository was archived by the owner on Nov 22, 2024. It is now read-only.
Is not working if DOMContentLoaded already fired#1104
Merged
CaerusKaru merged 1 commit intoangular:masterfrom Dec 25, 2018
Merged
Is not working if DOMContentLoaded already fired#1104CaerusKaru merged 1 commit intoangular:masterfrom
CaerusKaru merged 1 commit intoangular:masterfrom
Conversation
If `DOMContentLoaded` event already fired and after adding a listener for `DOMContentLoaded` event, then it will not execute. So added a check to resolve() the promise if DOMContentLoaded event already fired.
CaerusKaru
added
PR state: LGTM
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
DOMContentLoadedevent already fired and after adding a listener forDOMContentLoadedevent, then it will not execute.So added a check to resolve() the promise if DOMContentLoaded event already fired.