Cannot read property 'unsubscribe' of undefined

[Vayrex]

Note: for support questions, please use one of these channels: https://github.com/angular/universal/blob/master/CONTRIBUTING.md#question. This repository's issues are reserved for feature requests and bug reports.

• I'm submitting a ...
• [v ] bug report
• feature request
• support request => Please do not submit support request here, see note at the top of this template.
• What modules are related to this pull-request
• express-engine
• grunt-prerender
• gulp-prerender
• hapi-engine
• universal-preview
• [v ] universal
• webpack-prerender
• Do you want to request a feature or report a bug?

I want to report a bug.

• What is the current behavior?

I'm getting an error when changin a client side route and then reloading a page.

• If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem by creating a github repo.

Here is example of function

function ngApp(req, res) {

  let baseUrl = '/base';
  //need to remove base from original url
  let url = req.originalUrl.replace(baseUrl,'').slice(1) || '/';

  let config:ExpressEngineConfig = {
    directives: [AppComponent],
    platformProviders: [
      {provide: ORIGIN_URL, useValue: 'http://localhost:3000/base'},
      {provide: BASE_URL, useValue: baseUrl},
    ],
    providers: [
      {provide: REQUEST_URL, useValue: url},
      provideRouter(routes),
      NODE_LOCATION_PROVIDERS,
      NODE_HTTP_PROVIDERS,
    ],
    async: false,
    preboot: {appRoot:'vacay-app', buffer:true}
  };

  res.render('vacay', config);
}

Seems server side scripts does'n unsubscribes when needed and then is trying to unsubscribe from not yet subscribed route.
If set aync property to true there is no error.

• What is the expected behavior?
  Do not get this error.
• What is the motivation / use case for changing the behavior?
  Maybe it will help other developers.
• Please tell us about your environment:
• Angular version: 2.0.0-rc4
• Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX ]
• Language: TypeScript 1.
• OS: Linux
• Platform:NodeJs
• Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

Rendering Document Error: TypeError: Cannot read property 'unsubscribe' of undefined
    at Router.dispose (/home/vayrex/www/HORISONT/node_modules/@angular/router/src/router.js:189:32)
    at /home/vayrex/www/HORISONT/node_modules/@angular/router/src/common_router_providers.js:23:56
    at /home/vayrex/www/HORISONT/node_modules/@angular/core/src/application_ref.js:448:68
    at Array.forEach (native)
    at ApplicationRef_.dispose (/home/vayrex/www/HORISONT/node_modules/@angular/core/src/application_ref.js:448:32)
    at /home/vayrex/www/HORISONT/node_modules/angular2-universal/dist/node/bootloader.js:155:45
    at ZoneDelegate.invoke (/home/vayrex/www/HORISONT/node_modules/zone.js/dist/zone-node.js:281:29)
    at Zone.run (/home/vayrex/www/HORISONT/node_modules/zone.js/dist/zone-node.js:174:44)
    at /home/vayrex/www/HORISONT/node_modules/zone.js/dist/zone-node.js:529:58
    at ZoneDelegate.invokeTask (/home/vayrex/www/HORISONT/node_modules/zone.js/dist/zone-node.js:314:38)
TypeError: Cannot read property 'unsubscribe' of undefined
    at Router.dispose (/home/vayrex/www/HORISONT/node_modules/@angular/router/src/router.js:189:32)
    at /home/vayrex/www/HORISONT/node_modules/@angular/router/src/common_router_providers.js:23:56
    at /home/vayrex/www/HORISONT/node_modules/@angular/core/src/application_ref.js:448:68
    at Array.forEach (native)
    at ApplicationRef_.dispose (/home/vayrex/www/HORISONT/node_modules/@angular/core/src/application_ref.js:448:32)
    at /home/vayrex/www/HORISONT/node_modules/angular2-universal/dist/node/bootloader.js:155:45
    at ZoneDelegate.invoke (/home/vayrex/www/HORISONT/node_modules/zone.js/dist/zone-node.js:281:29)
    at Zone.run (/home/vayrex/www/HORISONT/node_modules/zone.js/dist/zone-node.js:174:44)
    at /home/vayrex/www/HORISONT/node_modules/zone.js/dist/zone-node.js:529:58
    at ZoneDelegate.invokeTask (/home/vayrex/www/HORISONT/node_modules/zone.js/dist/zone-node.js:314:38)

[MarkPieszak]

@Vayrex This is actually being caused by preboot's buffer: true.

You can track this issue in the preboot repo here: angular/preboot#4

[iamdenny]

I have same issue.
I tried to change buffer: true, but same error.
so I checked node_modules/@angular/router/src/router.js:171

When I click F5, this.locationSubscription is going to be undefined. that's why I can see the error Rendering Document Error: [TypeError: Cannot read property 'unsubscribe' of undefined]

[iamdenny]

When I visit the site first, It's called Router.prototype.setUpLocationChangeListener and then called Router.prototype.dispose so no error.

When I click F5(refresh button), It's called Router.prototype.dispose first and then Router.prototype.setUpLocationChangeListener.
that's why this.locationSubscription is empty.

How can I fix this error?

[iamdenny]

after upgrading @angular/router from 3.0.0-alpha.8 to 3.0.0-beta.2, the error is disappeared.

[MarkPieszak]

Glad to hear it! @iamdenny

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}