This repository was archived by the owner on Nov 22, 2024. It is now read-only.
feat(modules): pass in absolute URL as default for view rendering#897
Merged
CaerusKaru merged 2 commits intomasterfrom Dec 25, 2018
Merged
feat(modules): pass in absolute URL as default for view rendering#897CaerusKaru merged 2 commits intomasterfrom
CaerusKaru merged 2 commits intomasterfrom
Conversation
|
I think we should hold off on this till we have a concrete solution for how HttpClient will injest the base url |
Member
Author
|
@Toxicable I thought about that, but I think we can consider this a separate issue. Is there ever a case we want the URL passed in to not be absolute on the server? (at least by default) |
|
Blocked on deciding what we should do in core first |
Toxicable
added
the
target: minor
* Add the absolute URL to view generation to allow for access through the document's native location object * Future PR will allow user to override the default url
Toxicable
suggested changes
Dec 25, 2018
Toxicable
approved these changes
Dec 25, 2018
CaerusKaru
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the document's native location object
NOTE: This will act as a precursor to correct absolute path resolution for
HttpClient