Conversation
Toxicable
requested review from
CaerusKaru,
MarkPieszak and
vikerman
as code owners
| */ | ||
| export { TransferHttpCacheModule } from './src/transfer_http'; | ||
| export { StateTransferInitializerModule } from './src/state-transfer-initilizer/module'; | ||
| // export { StateTransferInitializerModule } from './src/state-transfer-initilizer/module'; |
There was a problem hiding this comment.
don't export this into v5 since it actually fails to compile and hasn't been validated.
Toxicable
added
action: review
target: major
| { | ||
| "extends": "./tsconfig.lib.json", | ||
| "files": [ | ||
| "./index.ts", |
There was a problem hiding this comment.
Don't need the ./ here, or elsewhere
There was a problem hiding this comment.
it was like that in the other tsconfigs so being consistent
There was a problem hiding this comment.
Ok then that's fine, didn't realize it was like that
| "./index.ts", | ||
| "./tokens.ts" | ||
| ], | ||
| "angularCompilerOptions": {} |
There was a problem hiding this comment.
the angularCompilerOptions ? we need to overide them since the ones declared in .lib conflict with our files declaration here
There was a problem hiding this comment.
ahh sweet as then, wasn't aware of that
Toxicable
force-pushed
the
fabian/build.sh-patch
branch
2 times, most recently
from
c6dc5b2 to
ac61431
Compare
BREAKING CHANGE: Tokens are now exported from @nguniversal/engineName/tokens This change fixes are regression where using these tokens in your browser app would increase the bundle size by about ~600kb.
Toxicable
force-pushed
the
fabian/build.sh-patch
branch
from
ac61431 to
32708e7
Compare
BREAKING CHANGE: Tokens are now exported from @nguniversal/engineName/tokens This change fixes a regression where using these tokens in your browser app would increase the bundle size by about ~600kb.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
BREAKING CHANGE: Tokens are now exported from @nguniversal/engineName/tokens
This change fixes are regression where using these tokens in your browser app would increase the bundle size by about ~600kb.
fixes: #920