Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

Conversation

@vikerman
Copy link
Contributor

This can help the firebase deploy builder(for instance) to call the either the browser build or prerender target uniformly with configuration set to production.

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Dec 11, 2019

firebase builder only works with build target, so this won’t make it possible to use it with firebase.

https://github.com/angular/angularfire/blob/76f721254bcb4e9db693486332a4a72a7e897f15/src/schematics/deploy/actions.ts#L29

@vikerman
Copy link
Contributor Author

@alan-agius4 - The idea is that we can make the target configurable for the deploy builders instead of always calling "build" similar to the azure one - https://github.com/Azure/ng-deploy-azure/blob/8c391d3d951c59c3d2a5e8b83566462a1af39321/src/builders/actions/deploy.ts#L68

If the target can be changed to "prerender" from "build" using the deploy config, ng deploy will build the static site and deploy it,

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Dec 12, 2019

I think ideally the builder should expose a parameter for which configuration target to run and deploy.

@vikerman
Copy link
Contributor Author

The production config is same as default config which already points to production versions of browser and server builds. It's being added just for uniformity and convenience

@alan-agius4
Copy link
Collaborator

Okay, let’s add it, but I still think it should be the builder the handles which configuration target to deploy.

@vikerman vikerman merged commit d978eb0 into angular:master Dec 12, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants