fix(desktop): change detection on Windows, especially Cygwin#13659
Merged
Hona merged 9 commits intoanomalyco:devfrom Feb 22, 2026
Merged
fix(desktop): change detection on Windows, especially Cygwin#13659Hona merged 9 commits intoanomalyco:devfrom
Hona merged 9 commits intoanomalyco:devfrom
Conversation
This was referenced Feb 15, 2026
Member
|
vouch @edemaine |
# Conflicts: # packages/opencode/src/util/filesystem.ts
# Conflicts: # packages/opencode/test/util/filesystem.test.ts
Hona
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12849: the Review tab on Desktop now works for me on Windows. The root cause turned out to be that I was using Cygwin's
git, which reports paths in a slightly funny way (/cygpath/c/...instead ofC:\...). But it's an easy fix. While I was figuring things out, I also improved a few related things related to the review panel and change detection.I separated out the changes into four commits, for easier review or dropping some changes if you don't approve them:
/project/currentto discover that VCS/git wasn't detected, which was the root cause for changes not being detected. I didn't even know changes were VCS based, though it makes sense. (I guessed as much in Review tab always empty on Windows #12849.) Now the user gets a helpful message if they open a non-VCS project, or as in my case, VCS wasn't correctly detected. This explains the no-changes behavior for non-VCS projects.giton my path is from Cygwin, which reports paths as/cygdrive/c/...instead ofC:\.... I also included support for/mnt/c/...style paths in case someone is using WSL git. Both of these path mappings only apply to win32 systems, so they should be relatively safe, and broaden support. I know Cygwin is niche, but I hope you'll consider the minor change necessary to support it. (For me it's a pain to run two types of Git, because they don't cooperate well on.gitfiles.)/c/...that should behave the same as (4), so I factored out a shared helper and used it there as well.How did you verify your code works?
bun run dev:desktop, in particular to see that file watching works better now. Also made changes to a file within a VCS project and saw them appear in the Changes panel.packages/apptests passpackages/opencodehas broader Windows test failures currently (many path-format expectation mismatches), but the number of failures went down from 74 to 43. I also have some more commits that reduce the number down to 8, but I think I'll leave them for a subsequent PR (fix: Windows path support and canonicalization #13671) as it targets far outside the Review tab.