Skip to content

Add 'write' role to vouch manage action#18718

Merged
Hona merged 1 commit intodevfrom
Hona-patch-1
Mar 23, 2026
Merged

Add 'write' role to vouch manage action#18718
Hona merged 1 commit intodevfrom
Hona-patch-1

Conversation

@Hona
Copy link
Member

@Hona Hona commented Mar 23, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 23, 2026 06:21
@Hona Hona enabled auto-merge (squash) March 23, 2026 06:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions workflow that manages vouch operations via issue comments to allow users with the write repository role (in addition to admin/maintain) to use the manage action.

Changes:

  • Expand the allowed roles passed to mitchellh/vouch/action/manage-by-issue to include write.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@atharvau atharvau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow Permissions Review - APPROVED ✅

Simple and appropriate change to workflow permissions.

Change Analysis ✅

  • LOW-RISK: Adds 'write' role to vouch manage action
  • Extends access from admin/maintain to include write permissions
  • Follows principle of least privilege while enabling necessary functionality

Security Considerations ✅

  • Write permissions are appropriate for vouch management actions
  • Still restricts to trusted roles (admin, maintain, write)
  • Does not grant broader access than necessary

Code Quality ✅

  • Minimal, focused change
  • Clear intent and scope
  • No unintended side effects

Overall Assessment: This is a straightforward permission adjustment that appears necessary for the workflow functionality. The change is minimal and appropriate.

@Hona Hona merged commit db9619d into dev Mar 23, 2026
15 checks passed
@Hona Hona deleted the Hona-patch-1 branch March 23, 2026 06:27
@Hona
Copy link
Member Author

Hona commented Mar 23, 2026

denounce @atharvau AI review spamming literally every PR

opencode-agent bot pushed a commit that referenced this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants