fix: report change in check mode when schema exists and state is absent

[allartk]

SUMMARY

Removing an existing schema in check mode does not report changes.
However, removing a non-existing schema in check mode does.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

postgresql_schema

ADDITIONAL INFORMATION

Example

- name: Remove londiste schema from database
  become: true
  become_user: postgres
  community.postgresql.postgresql_schema:
    name: londiste
    login_db: "{{ item.db }}"
    port: "{{ item.port }}"
    state: absent
    cascade_drop: true
  loop: "{{ londiste_cleanup }}"

[allartk]

PS: could use some help (if the change is correct) with the tests...

[andreasscherbaum]

There's an assert somewhere in the code, which is failing:

TASK [postgresql_schema : assert] **********************************************
02:23 task path: /root/ansible_collections/community/postgresql/tests/output/.tmp/integration/postgresql_schema-xqby83rh-ÅÑŚÌβŁÈ/tests/integration/targets/postgresql_schema/tasks/postgresql_schema_initial.yml:100
02:23 fatal: [testhost]: FAILED! => {
02:23     "assertion": "result is not changed",
02:23     "changed": false,
02:23     "evaluated_to": false,
02:23     "msg": "Assertion failed"
02:23 }

[hunleyd]

needs a changelog fragment before merging

[Andersson007]

@allartk thanks for submitting the fix

1. You need to fix CI as Andreas pointed out, in particular the task tests/integration/targets/postgresql_schema/tasks/postgresql_schema_initial.yml:100
2. See https://docs.ansible.com/ansible/devel/community/create_pr_quick_start.html how to run tests locally
3. And the fragments pointed out by Doug

[allartk]

Thanks for the feedback, I'll try to fix, as soon as my schedule allows it.

[Andersson007]

@allartk thanks for the fix!
@hunleyd @andreasscherbaum thanks for reviewing and merging!
I'll release now, FYI

[patchback]

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/8b2d17b84bcd7f5459fd050a43e82b01f987d147/pr-858

Backported as #861

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.