pin surge and colors [npm] #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Tested in this run: https://github.com/briantist/gha-junk/runs/4751359455?check_suite_focus=true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12
Related to #10
This pins the version of
surge@0.23.0, which happens to be current version being installed.It also separately installs
colors@1.4.0to temporarily resolve #12, until one of either the colors package is back under control or surge pins its dependency or both.I would like to further look into whether there's an even better way to do this. I looked around for a bit, messing with
packages-lock.jsonandnpm shrinkwrapbut I didn't come up with anything viable (as I'm not well-versed in nodejs at all).