Ignore .js and .inv files for diff #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantist
approved these changes
Jan 9, 2022
Collaborator
|
I am thinking we could let this close #2, it solves the issue for the time being, and we can reopen or resubmit later if we think we need more on this front, options could be:
thoughts? |
Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
…fore merging." This reverts commit 56a093b.
felixfontein
changed the title
Collaborator
Author
|
Sounds good. I've adjustd the text. |
Collaborator
Author
|
@briantist thanks for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the ansible-docs-build-diff action to delete
.jsand.invfiles before doing the diff. Since this is after uploading the artefact, it shouldn'd break anything :)I'm resuing the same branch name as before so I don't have to change community.docker's main branch ;) I've tested this in ansible-collections/community.docker#280 as well; as you can see the diff there is now only the modified HTML file.
Fixes #2.
This cannot be merged yet since one commit needs to be reverted (the one changing the workflow). I'll do that after review.