Add Zizmor Scanning on push/pull request #3141
+29
−0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,29 @@ | ||||||||||||||||||
| name: GitHub Actions Security Analysis with zizmor 🌈 | ||||||||||||||||||
|
|
||||||||||||||||||
| on: | ||||||||||||||||||
| schedule: | ||||||||||||||||||
| # Daily | ||||||||||||||||||
| - cron: "23 7 * * *" | ||||||||||||||||||
| push: | ||||||||||||||||||
| paths: | ||||||||||||||||||
| - .github/workflows/* | ||||||||||||||||||
| pull_request: | ||||||||||||||||||
| paths: | ||||||||||||||||||
| - .github/workflows/* | ||||||||||||||||||
|
Comment on lines
+9
to
+12
There was a problem hiding this comment. Let's make this future-proof if the project ever starts using in-tree actions. Also, I'd still run it on PR merge every time, for faster feedback:
Suggested change
|
||||||||||||||||||
|
|
||||||||||||||||||
| permissions: {} | ||||||||||||||||||
|
|
||||||||||||||||||
| jobs: | ||||||||||||||||||
| zizmor: | ||||||||||||||||||
| name: Run zizmor 🌈 | ||||||||||||||||||
| runs-on: ubuntu-latest | ||||||||||||||||||
| permissions: | ||||||||||||||||||
| security-events: write | ||||||||||||||||||
| steps: | ||||||||||||||||||
| - name: Checkout repository | ||||||||||||||||||
| uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 | ||||||||||||||||||
oraNod marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||
| with: | ||||||||||||||||||
| persist-credentials: false | ||||||||||||||||||
|
|
||||||||||||||||||
| - name: Run zizmor 🌈 | ||||||||||||||||||
| uses: zizmorcore/zizmor-action@e673c3917a1aef3c65c972347ed84ccd013ecda4 # v0.2.0 | ||||||||||||||||||
|
Comment on lines
+16
to
+29
There was a problem hiding this comment. @x1101 could you just use the reusable workflow instead of duplicating the job steps? As in this example: #2681 (comment) |
||||||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use a more specific name than just scan. It's too generic and can refer to just about anything.