Fixing a bug in test_display_galaxy_info

[s-hertel]

ISSUE TYPE

• Bugfix Pull Request

ANSIBLE VERSION

ansible 2.1.0.0
  config file =
  configured module search path = Default w/o overrides

SUMMARY

find() returns -1 if it fails and the string 'galaxy_tags' isn't in ever in display_result in this test. The bug doesn't result in any errors because the logic is sort of inverted- i.e. if it finds galaxy_tags indented twice (which it won't, since galaxy_tags isn't there) then raise an error informing user that galaxy_tags should be indented twice.
I changed it to find something that is supposed to be there (galaxy_info) and changed the logic to raise an error if it is not found.

before fix:

shertel-OSX:ansible shertel$ PYTHONPATH=./lib nosetests -d -w test/units -v -s cli.test_galaxy
test_display_galaxy_info (cli.test_galaxy.TestGalaxy) ... ok
test_display_min (cli.test_galaxy.TestGalaxy) ... ok
test_init (cli.test_galaxy.TestGalaxy) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.001s

OK

after fix:

shertel-OSX:ansible shertel$ PYTHONPATH=./lib nosetests -d -w test/units -v -s cli.test_galaxy
test_display_galaxy_info (cli.test_galaxy.TestGalaxy) ... ok
test_display_min (cli.test_galaxy.TestGalaxy) ... ok
test_init (cli.test_galaxy.TestGalaxy) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.001s

OK

[s-hertel]

Closed in favor of #16783; just updated for merge conflicts.