Skip to content
This repository was archived by the owner on Sep 16, 2020. It is now read-only.

remove the unnecessary lib path and package_dir specification#250

Merged
ryanpetrello merged 1 commit intoansible:masterfrom
ryanpetrello:master
Mar 1, 2017
Merged

remove the unnecessary lib path and package_dir specification#250
ryanpetrello merged 1 commit intoansible:masterfrom
ryanpetrello:master

Conversation

@ryanpetrello
Copy link
Contributor

this also fixes breakage of pip install -e .

@jlaska jlaska added the review label Mar 1, 2017
this is breaking usage of `pip install -e .`
@coveralls
Copy link

coveralls commented Mar 1, 2017

Coverage Status

Coverage remained the same at 98.408% when pulling cf1d6ea on ryanpetrello:master into 0b2a22d on ansible:master.

@AlanCoding
Copy link
Member

AlanCoding commented Mar 1, 2017

Travis says that it passed, but if you click into it, it looks like other python versions are failing. Those look slightly familiar, but I don't see them on other recent pull requests. I might re-run the tests in a second to be sure.

EDIT: yes, I think that was the case, sorry for the noise.

@AlanCoding
Copy link
Member

maybe it had a stale link. I had seen https://travis-ci.org/ansible/tower-cli/builds/206680594, but maybe this isn't the most recent.

@ryanpetrello
Copy link
Contributor Author

The most recent build I see seems to be passing: https://travis-ci.org/ansible/tower-cli/builds/206686598

Copy link
Member

@AlanCoding AlanCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively big change, but that sounds good it for the 3.1 release.

@ryanpetrello ryanpetrello merged commit a22cab0 into ansible:master Mar 1, 2017
@jlaska jlaska removed the review label Mar 1, 2017
@jangsutsr
Copy link
Contributor

@ryanpetrello My salute to you! A lib directory is so confusing (a dynamic runtime library in a Python repo?) and I've always wanted it removed 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants