This repository was archived by the owner on Sep 16, 2020. It is now read-only.
Expose --wait option for projects and groups#265
Merged
AlanCoding merged 1 commit intoansible:masterfrom Mar 8, 2017
Merged
Conversation
jangsutsr
approved these changes
Mar 8, 2017
Contributor
jangsutsr
left a comment
jangsutsr
left a comment
There was a problem hiding this comment.
Once test failure is handled this is good to go.
Member
Author
|
My test fix was: self.assertIn((42,), isrc_sync.call_args)I'd like to use this pattern in more places to avoid more duplicate code, because we cary through a lot of redundant kwargs that aren't relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the process of testing out the master branch, I noticed this. This makes it so that commands like this work:
tower-cli project create --name="dup2" --organization "Default" --scm-type git --scm-url https://github.com/AlanCoding/permission-testing-playbooks.git --waitWe had it for jobs, and most of the code was already in place but they also needed to be added as options.