Skip to content
This repository was archived by the owner on Sep 16, 2020. It is now read-only.

Refactor to have cli directory.#307

Merged
jangsutsr merged 1 commit intoansible:masterfrom
jangsutsr:refactor_to_have_cli_dir
Jul 5, 2017
Merged

Refactor to have cli directory.#307
jangsutsr merged 1 commit intoansible:masterfrom
jangsutsr:refactor_to_have_cli_dir

Conversation

@jangsutsr
Copy link
Contributor

First step towards transferring Tower CLI from CLI to CLI + Python lib.

@jangsutsr jangsutsr requested a review from AlanCoding June 8, 2017 20:31
@coveralls
Copy link

coveralls commented Jun 8, 2017

Coverage Status

Coverage decreased (-1.2%) to 89.549% when pulling 72cf8d4 on jangsutsr:refactor_to_have_cli_dir into fb6540b on ansible:master.

@AlanCoding AlanCoding requested a review from ryanpetrello June 12, 2017 14:10
@AlanCoding
Copy link
Member

In the release notes of the version this goes out in, I want to specifically call out the deprecation of as_command, and note the new class for subcommands. Also, specifically note that get_resource will continue to work as usual (this should be the most common use pattern).

Those have some risk of impacting people who have built off of tower-cli, but I think it's sufficiently small, and I'm good with shipping this.

@jangsutsr jangsutsr merged commit 3e46a49 into ansible:master Jul 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants