This repository was archived by the owner on Sep 16, 2020. It is now read-only.
Explicitly add Loader to yaml.load #680
Merged
jainnikhil30 merged 5 commits intoansible:masterfrom Mar 22, 2019
jainnikhil30:master
Merged
Explicitly add Loader to yaml.load #680jainnikhil30 merged 5 commits intoansible:masterfrom jainnikhil30:master
jainnikhil30 merged 5 commits intoansible:masterfrom
jainnikhil30:master
Conversation
…More info here h[Dttps://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation
AlanCoding
reviewed
Mar 21, 2019
tests/test_resources_job.py
Outdated
| self.assertDictContainsSubset( | ||
| {"spam": "eggs"}, | ||
| yaml.load(edit.mock_calls[0][1][0]) | ||
| yaml.load(edit.mock_calls[0][1][0], Loader=yaml.FullLoader) |
Member
There was a problem hiding this comment.
is there any reason to not make these SafeLoader?
Contributor
Author
There was a problem hiding this comment.
ah my bad. I missed that. I will change that too
Thanks.
AlanCoding
approved these changes
Mar 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #675 #676