Skip to content
This repository was archived by the owner on Sep 16, 2020. It is now read-only.

fixing required not being present in inputs for custom credentials#690

Merged
AlanCoding merged 2 commits intoansible:masterfrom
jainnikhil30:master
Apr 1, 2019
Merged

fixing required not being present in inputs for custom credentials#690
AlanCoding merged 2 commits intoansible:masterfrom
jainnikhil30:master

Conversation

@jainnikhil30
Copy link
Contributor

@jainnikhil30 jainnikhil30 commented Apr 1, 2019

Fixes #641

@coveralls
Copy link

coveralls commented Apr 1, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 64.436% when pulling 1e377c4 on jainnikhil30:master into f210a85 on ansible:master.

AlanCoding
AlanCoding suggested changes Apr 1, 2019
View reviewed changes
Copy link
Member

@AlanCoding AlanCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, sorry, I might have read wrong earlier.

I can't see why you removed the in operation. It looks like field['id'] in should not have been removed

@jainnikhil30
Copy link
Contributor Author

jainnikhil30 commented Apr 1, 2019

@AlanCoding

Apologies for the oversight. My bad. Changed that.
Thanks for your review.

@jainnikhil30 jainnikhil30 requested a review from AlanCoding April 1, 2019 13:58
@AlanCoding AlanCoding merged commit 9a571f6 into ansible:master Apr 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@AlanCoding AlanCoding AlanCoding approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jainnikhil30 @coveralls @AlanCoding