Skip to content

Add version on Delete requests #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Add version on Delete requests #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ansys/api/acp/v0/model.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ message ModelRequest {
ResourcePath resource_path = 1;
}

message DeleteModelRequest {
BasicInfo info = 1;
}

message ModelInfo {
BasicInfo info = 1;
message ModelingProperties {
Expand Down Expand Up @@ -72,7 +76,7 @@ service Model {

rpc Put(ModelInfo) returns (ModelInfo);

rpc Delete(ModelRequest) returns (Empty);
rpc Delete(DeleteModelRequest) returns (Empty);

rpc Update(UpdateModelRequest) returns (ModelInfo); // TODO: return changed entitites

Expand Down
6 changes: 5 additions & 1 deletion ansys/api/acp/v0/modeling_group.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ message PutModelingGroupRequest {
BasicInfo info = 1;
}

message DeleteModelingGroupRequest {
BasicInfo info = 1;
}

message ListModelingGroupsRequest {
CollectionPath collection_path = 1;
}
Expand All @@ -36,7 +40,7 @@ service ModelingGroup {

rpc Put(PutModelingGroupRequest) returns (ModelingGroupReply);

rpc Delete(ModelingGroupRequest) returns (Empty);
rpc Delete(DeleteModelingGroupRequest) returns (Empty);

rpc Create(CreateModelingGroupRequest) returns (ModelingGroupReply);
}