add ply_type to the material properties

[roosre]

No description provided.

[greschd]

Thanks @roosre, just one question.

[greschd]

Are we using this in different objects, or could it be defined directly in the materials.proto?

[roosre]

The ply type is only used by the material, at least as defining property. It is used in several places in the current UI though (ESAComp export, upgrade Mechanism). Do you prefer to move it to materials.proto?

[ojkoenig]

As you asked me to look at the PRs, I'll comment as well:
Looks like you define a new enum here, and there is already something called "enum_types.proto", why not add it there?

[roosre]

The name of the values have to be unique per namespace and I thought that UNKNOWN is used for the Status and PlyType but this is not the case.

[ojkoenig]

Was curious about the scopes of enums for protobuf, so I quickly googled, finding this:

Here they say in C++ it maps to C++ scoping rules, meaning you cannot have two enums with same values.
https://protobuf.narkive.com/6BXBO4QR/enum-values-are-siblings-of-their-type-not-children-of-it

This is probably why the protobuf doc here uses unique enum values with 'enum_name'_'value' :
https://developers.google.com/protocol-buffers/docs/proto3#enum
?

[ojkoenig]

General question:
From this PR and the one on ACP side it looks a bit look you keep the proto defs manually in sync in acp kernel and pyacp repo? I would expect that protos are defined in one place and then be consumed as some sort of pkg/zip on the other end?

[ojkoenig]

As you asked me to look at the PRs, I'll comment as well:
Looks like you define a new enum here, and there is already something called "enum_types.proto", why not add it there?