feat: Provide logger formatter separately #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnal/ansys-tools-common into feat/logger-formatter
RobPasMue
approved these changes
Aug 25, 2025
Member
RobPasMue
left a comment
RobPasMue
left a comment
There was a problem hiding this comment.
Small comment on my side - LGTM otherwise
ludovicsteinbach
left a comment
ludovicsteinbach
left a comment
There was a problem hiding this comment.
I believe exposing the formatter in the right thing to do. I have added a couple comments on mutability
da1910
reviewed
Aug 25, 2025
da1910
left a comment
da1910
left a comment
There was a problem hiding this comment.
This is definitely better than the first proposal, but I'm not entirely convinced still.
Overall I think agreeing on a common order for log items is well worthwhile, likewise agreeing on what each level means. Going further, I'd advocate for ideally picking a structured logging format (structlog for example), or rolling our own, since that will make observability a lot easier overall.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
After discussion, let's move forward to provide the formatter separately and not enforce the use of the singleton.
The singleton is kept since I think mostly tooling libraries can seize it.
Implementation details
As title says. I separated the formatter from the logger to avoid loading the singleton every time. Testing should be already covered by logger tests.