Skip to content

fix: Uninitialized variable in PyVistaBackendInterface #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 6, 2025
Merged

fix: Uninitialized variable in PyVistaBackendInterface #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f9ea3c
fix: Uninitialized variable in PyVistaBackendInterface
AlejandroFernandezLuces Oct 6, 2025
0b7e807
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 6, 2025
ccf6ed1
chore: adding changelog file 375.miscellaneous.md [dependabot-skip]
pyansys-ci-bot Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/375.miscellaneous.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix: Uninitialized variable in PyVistaBackendInterface
2 changes: 2 additions & 0 deletions src/ansys/tools/visualization_interface/backends/pyvista/pyvista.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ def __init__(
# Map that relates PyVista actors with PyAnsys objects
self._object_to_actors_map = {}

self._edge_actors_map: Dict[pv.Actor, EdgePlot] = {}

# PyVista plotter
self._pl = None

Expand Down
6 changes: 4 additions & 2 deletions tests/test_generic_plotter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
import pytest
import pyvista as pv

from ansys.tools.visualization_interface import ClipPlane, MeshObjectPlot, Plotter
from ansys.tools.visualization_interface import ClipPlane, EdgePlot, MeshObjectPlot, Plotter
from ansys.tools.visualization_interface.backends.pyvista import PyVistaBackend
from ansys.tools.visualization_interface.backends.pyvista.picker import Picker

Expand Down Expand Up @@ -93,7 +93,9 @@ def test_plotter_add_structured_grid():
def test_plotter_add_custom():
"""Adds a MeshObjectPlot object to the plotter."""
sphere = pv.Sphere()
custom = MeshObjectPlot(CustomTestClass("myname"), sphere)
edge = pv.Cube((0, 1, 0))
custom_edge = EdgePlot(CustomTestClass("myname_edge"), edge)
custom = MeshObjectPlot(CustomTestClass("myname"), sphere, edges=[custom_edge])
pl = Plotter()
pl.plot(custom)
pl.show()
Expand Down
Loading