Skip to content

Conversation

Andy-Grigg
Copy link
Contributor

@Andy-Grigg Andy-Grigg commented Feb 18, 2022

Closes #145

Changes the name of the package in the pip command. The text can now be copied as-is to the command line to install the necessary packages. I have also fixed the similar linux-kerberos exception text.

@Andy-Grigg Andy-Grigg requested a review from da1910 February 18, 2022 21:13
@Andy-Grigg Andy-Grigg marked this pull request as draft February 18, 2022 21:24
Copy link
Collaborator

@da1910 da1910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better!

@Andy-Grigg
Copy link
Contributor Author

Looks better!

I was a bit overeager in marking this as ready for review...

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #146 (0625ee6) into main (f876e3a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files           8        8           
  Lines         821      821           
=======================================
  Hits          754      754           
  Misses         67       67           
Impacted Files Coverage Δ
src/ansys/openapi/common/_session.py 87.57% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f876e3a...0625ee6. Read the comment docs.

@Andy-Grigg Andy-Grigg marked this pull request as ready for review February 18, 2022 22:12
@Andy-Grigg Andy-Grigg requested a review from da1910 February 18, 2022 22:12
Copy link
Collaborator

@da1910 da1910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I had updated these already, oh well. Looks good 👍

@da1910 da1910 merged commit ef79a5d into main Feb 19, 2022
@Andy-Grigg Andy-Grigg deleted the fix/wrong-oidc-error-message branch February 20, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong error message when OIDC extra isn't installed

2 participants