Skip to content

Conversation

da1910
Copy link
Collaborator

@da1910 da1910 commented Apr 4, 2022

Bumping sphinx unblocks requests, which then triggers a new version of the requests type stubs. These are now more strict, and so we need to match them in the signature for our RetryAdapter.

@da1910 da1910 requested a review from Andy-Grigg April 4, 2022 13:58
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #177 (b11adaa) into main (b5bb855) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   91.88%   91.88%           
=======================================
  Files           8        8           
  Lines         826      826           
=======================================
  Hits          759      759           
  Misses         67       67           
Impacted Files Coverage Δ
src/ansys/openapi/common/_session.py 87.57% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5bb855...b11adaa. Read the comment docs.

Copy link
Contributor

@Andy-Grigg Andy-Grigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@da1910 da1910 merged commit cad8906 into main Apr 4, 2022
@da1910 da1910 deleted the maint/bump-sphinx-4.5.0 branch April 4, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants