Skip to content

Conversation

da1910
Copy link
Collaborator

@da1910 da1910 commented Apr 4, 2022

  1. Typo in ApiException.headers - "defeault" -> "default"
  2. Add intersphinx links in .deserialize

- Typo in ApiException
- Add intersphinx links in .deserialize
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #179 (f69a5c5) into main (72e908a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #179   +/-   ##
=======================================
  Coverage   91.88%   91.88%           
=======================================
  Files           8        8           
  Lines         826      826           
=======================================
  Hits          759      759           
  Misses         67       67           
Impacted Files Coverage Δ
src/ansys/openapi/common/_api_client.py 97.93% <ø> (ø)
src/ansys/openapi/common/_exceptions.py 97.56% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72e908a...f69a5c5. Read the comment docs.

Copy link
Contributor

@Andy-Grigg Andy-Grigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@Andy-Grigg
Copy link
Contributor

My assumption is that once the other PR is merged to fix the mypy failure, these tests will all go green.

@da1910 da1910 merged commit 5bdaf8f into main Apr 4, 2022
@da1910 da1910 deleted the doc/152-minor-docs-fixes branch April 4, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants