generated from ansys/template
-
Notifications
You must be signed in to change notification settings - Fork 0
FEAT 222 Add client credential flow #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch session creation - Update some tests (2 are failing)
- Remove OIDCCallbackHTTPServer and tests - Remove HTTPResponseHandler and tests
Codecov Report
@@ Coverage Diff @@
## main #223 +/- ##
==========================================
+ Coverage 91.88% 93.44% +1.56%
==========================================
Files 8 8
Lines 826 809 -17
==========================================
- Hits 759 756 -3
+ Misses 67 53 -14
Continue to review full report at Codecov.
|
Closing this to try and clean up diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #222
This PR includes a very rough initial implementation of the client credential flow from requests-auth:
with_oauth()
method towith_oauth_pkce()
with_oauth_client_credentials()
I suspect there's a lot of duplication here, and that this isn't necessarily the most user-friendly way of doing it. Adding another level of builder also doesn't seem sensible though.
PR is based on both #221 and #139 , hence the large number of commits.
Tested against a real service implementing OIDC client credential flow and confirmed working.