-
Notifications
You must be signed in to change notification settings - Fork 0
Use ansys standard actions #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
=======================================
Coverage 94.25% 94.25%
=======================================
Files 7 7
Lines 783 783
=======================================
Hits 738 738
Misses 45 45 ☔ View full report in Codecov by Sentry. |
to match action expectation
for more information, see https://pre-commit.ci
f4b6d46
to
9e3e7fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly a change in the cname file, at least a question
pyproject.toml
Outdated
sphinx-notfound-page = { version = "1.0.0" } | ||
sphinx-copybutton = { version = "0.5.2" } | ||
# Duplicate extra - required to use ansys/actions/doc-build | ||
requests-kerberos = {version = "^0.13", markers = "sys_platform == 'linux'" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We ought to submit a ticket to get extras supported by actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up extracting a dependency to a new group.
Dev dependencies are not optional, so they get installed by poetry install
, which is what actions typically use. Because asgi_gssapi
requires gssapi
, most jobs required installing kerberos headers.
It's now installed via the tox env config, and thus is only required for tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember if we have any instructions for developers, but we should think about whether can can add a note to make sure it's clear we do need to add this to develop on the linux tests
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Doug Addy <doug.addy@ansys.com> Co-authored-by: pyansys-ci-bot <pyansys.github.bot@ansys.com>
Closes #549
Start #494
Use Ansys actions for doc build and deployment.
This will temporarily deploy to a new gh-page site, as this is still using a second repo for the docs. This actually gives us an opportunity to confirm all works well before switching out the CNAME.
Required follow-up tasks: