generated from ansys/template
-
Notifications
You must be signed in to change notification settings - Fork 0
CI - 574 - Update codecov action to v4 #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7366561
Update ci_cd.yml
da1910 1aaab54
Adding changelog entry: 575.changed.md
pyansys-ci-bot 5447435
try to ignore doc/changelog.d
klmcadams 07b9004
test changelog.d is ignored & other files are not
klmcadams 58da0f0
test that v6 catches vale warning
klmcadams 703fb25
check that changelog.d is only ignored
klmcadams 238e233
uncomment ci_cd & remove test line from contributing.rst
klmcadams 1d30315
test changelog.d is not ignored
klmcadams 93a4d6f
add ignore-changelogd to doc-style
klmcadams c46b99b
uncomment ci_cd and remove test sentence from contributing.rst
klmcadams 2e8be17
Merge branch 'main' into ci/codecov_4
da1910 316b4b8
Update ci_cd.yml
da1910 0b01181
Merge branch 'main' into ci/codecov_4
da1910 eb321ac
Merge branch 'main' into ci/codecov_4
da1910 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| CI - 574 - Update codecov action to v4 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,6 @@ | ||
| * | ||
| !Vocab | ||
| !Vocab/** | ||
| !config | ||
| !config/vocabularies | ||
| !config/vocabularies/ANSYS | ||
| !config/vocabularies/ANSYS/** | ||
| !.gitignore |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we should add this directory to an exclusion? It's irritating, because in general it's good to spellcheck these things, but we don't want to be adding individual exemptions for individual packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I raised ansys/actions#477 - It's going to happen to everyone, we should do it centrally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the approach for getting this PR merged then, are we blocked until that ticket is resolved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A splendid question, we could update our exclusion regex, but I don't know if you can exclude based on paths, or only on filenames. I wonder what pyMapdl is doing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/ansys/pymapdl/blob/42ef51351b0b3db0ff8a7c3cc84406abd07c6fe9/doc/.vale.ini#L37C1-L37C16 one solution I suppose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we already have the Vale.Terms = No included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I subsequently realised this, so I'm puzzled. Theres no exclusion in their pre-commit config file that I can see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we just add
codecovas an allowed word