Skip to content

Conversation

da1910
Copy link
Collaborator

@da1910 da1910 commented Sep 12, 2024

PyPI verifies the package URL if it points at the source repository. We have not updated this since the migration from pyansys, so lets do it!

@da1910 da1910 requested a review from Andy-Grigg September 12, 2024 14:21
@github-actions github-actions bot added documentation Improvements or additions to documentation maintenance Package and maintenance related labels Sep 12, 2024
Copy link
Contributor

@Andy-Grigg Andy-Grigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to be better at PR titles, since they now appear in the release notes.

The 'DOC' is unneeded, because the label fulfils this role. The title should also be more descriptive, something like "Update package repository URL in pyproject.toml"

@da1910 da1910 changed the title DOC - Update source link Update Repository URL in pyproject.toml Sep 12, 2024
@da1910
Copy link
Collaborator Author

da1910 commented Sep 12, 2024

I dislike that the labeller triggers a second CI run...

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.44%. Comparing base (a09ae2f) to head (03afb67).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #665   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files           7        7           
  Lines         792      792           
=======================================
  Hits          748      748           
  Misses         44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@da1910 da1910 added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit 4122b2d Sep 12, 2024
35 of 36 checks passed
@da1910 da1910 deleted the docs/verified_url branch September 12, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants