Skip to content

Conversation

Andy-Grigg
Copy link
Contributor

Closes #705

This PR was originally going to just include the README in the HTML documentation, but I realize the HTML documentation differs significantly from the other PyAnsys documentation styles in terms of structure, so I took this opportunity to re-organize things.

The PyAnsys approach is to include minimal info in the README, limited mainly to installation and getting started. The docs now mirror that approach, and use a sphinx-design gallery to link to other locations. The content from the README has moved to a new User Guide document, which describes how to use openapi-common.

@Andy-Grigg Andy-Grigg requested a review from da1910 October 31, 2024 17:58
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 31, 2024
@github-actions github-actions bot added dependencies Related with project dependencies maintenance Package and maintenance related labels Oct 31, 2024
@codecov
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.43%. Comparing base (a8a1eb1) to head (6e7ca08).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #706   +/-   ##
=======================================
  Coverage   94.43%   94.43%           
=======================================
  Files           7        7           
  Lines         791      791           
=======================================
  Hits          747      747           
  Misses         44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@da1910 da1910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise looks reasonable

Co-authored-by: Doug Addy <da1910@users.noreply.github.com>
@Andy-Grigg Andy-Grigg enabled auto-merge November 1, 2024 12:08
@Andy-Grigg Andy-Grigg added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit 909f5cc Nov 1, 2024
36 checks passed
@Andy-Grigg Andy-Grigg deleted the doc/merge-readme-and-docs branch November 1, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related with project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include README.rst in doc/ files

3 participants