Skip to content

Conversation

da1910
Copy link
Collaborator

@da1910 da1910 commented Apr 8, 2025

We currently only support providing a refresh token for OIDC use, this is certainly a more robust solution but not all IDPs and deployments are configured to allow the offline_access scope, and sometimes we do not have access to a refresh token at all.

This PR allows users to provide an access token for short-lived scripts.

@da1910 da1910 requested a review from Andy-Grigg April 8, 2025 11:48
@github-actions github-actions bot added the enhancement New features or code improvements label Apr 8, 2025
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.40%. Comparing base (68db120) to head (9ef3362).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/openapi/common/_session.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #773      +/-   ##
==========================================
- Coverage   94.43%   94.40%   -0.03%     
==========================================
  Files           7        7              
  Lines         790      804      +14     
==========================================
+ Hits          746      759      +13     
- Misses         44       45       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Andy-Grigg Andy-Grigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth doing a 2.2.3 patch release?

@da1910 da1910 merged commit 4405438 into main Apr 11, 2025
29 of 31 checks passed
@da1910 da1910 deleted the feat/772-OIDC-with-access-token branch April 11, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants