Skip to content

Conversation

da1910
Copy link
Collaborator

@da1910 da1910 commented Apr 14, 2025

Latest versions of the source action prevent it being used in reusable workflows, so ansys actions have removed support from their publish action. Replace this with the source action directly in our release job.

@da1910 da1910 requested a review from ludovicsteinbach April 14, 2025 10:06
@github-actions github-actions bot added the maintenance Package and maintenance related label Apr 14, 2025
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.40%. Comparing base (c7fe364) to head (26f5c69).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #777   +/-   ##
=======================================
  Coverage   94.40%   94.40%           
=======================================
  Files           7        7           
  Lines         804      804           
=======================================
  Hits          759      759           
  Misses         45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- name: "Upload artifacts to PyPI using trusted publisher"
uses: pypa/gh-action-pypi-publish@76f52bc884231f62b9a034ebfe128415bbaabdfc # v1.12.4
with:
repository-url: "https://upload.pypi.org/legacy/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to specify the url?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the example the Pyansys team give in the migration docs, the only change I made was to update the version of actions/download-artifact

@da1910 da1910 added this pull request to the merge queue Apr 14, 2025
Merged via the queue into main with commit 725f3e9 Apr 14, 2025
32 checks passed
@da1910 da1910 deleted the ci/fix-trusted-publisher-for-v9 branch April 14, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants