Add Edge Set tree object class #126
Conversation
greschd
force-pushed
the
feat/edge_set
branch
from
057b928 to
07cf4d8
Compare
| Name of the Edge Set. | ||
| edge_set_type : | ||
| Determines how the Edge Set is defined. Can be either :attr:`.EdgeSetType.BY_NODES` | ||
| or :attr:`.EdgeSetType.BY_REFERENCE`. |
There was a problem hiding this comment.
The same as in ACP. BY_REFERENCE tells the customer nothing.
What about or :attr:.EdgeSetType.BY_REFERENCE which means by :class:ElementSet.
Or you just read the doc of the other properties. :-)
There was a problem hiding this comment.
Improved by (almost) copying the GUI tooltips 👍
| def __init__( | ||
| self, | ||
| name: str = "EdgeSet", | ||
| edge_set_type: EdgeSetType = EdgeSetType.BY_NODES, |
There was a problem hiding this comment.
Default in ACP is by reference, and I think that also makes more sense.
| Element Set whose boundary the Edge Set follows. | ||
| Only applies when ``edge_set_type`` is :attr:`.EdgeSetType.BY_REFERENCE`. | ||
| limit_angle : | ||
| Maximum angle above which the remaining Element Set boundary is no |
There was a problem hiding this comment.
Should we document here that -1 stand for no or suppressed limit angle to walk around the entire Element Set?
And I guess the angle is in degree? Please document.
There was a problem hiding this comment.
Hmm, I'm tempted to add a conversion from None to -1, to avoid the magic number.
There was a problem hiding this comment.
In this case, there is typically a bool to control whether the property is active (can be set or not)
So we would have to add another parameter: trim edge set. If true, the user can set the limit angle.
What do you think? Can also be addressed later. Or we implement it in pyACP and apply the change to ACP kernel later.
There was a problem hiding this comment.
Hmm, in that case I think we can do it later.
If we do it just on the PyACP side, there's no way to recover the previous value when it's turned off and on again.
There was a problem hiding this comment.
There's a sneaky way we could implement this.. by just flipping the sign (AFAICT, all negative values disable cropping). But I think that logic is a bit too potentially confusing. In any case, we can always add a nicer way to handle this later.
In any case, I now documented to use -1. for turning it off.
greschd
force-pushed
the
feat/edge_set
branch
from
8357772 to
be7fbe7
Compare
TODO: